TrackUnionStream.cpp: Value stored to 'inputTrackEndPoint' is never read
Categories
(Core :: Audio/Video: Playback, defect, P3)
Tracking
()
People
(Reporter: Sylvestre, Assigned: emceeaich)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
A good first bug to test the contribution workflow
http://sylvestre.ledru.info/reports/fx-scan-build/report-TrackUnionStream.cpp-CopyTrackData-24-1.html#EndPath
The line can probably be safely removed
Reporter | ||
Comment 1•6 years ago
|
||
Note that we have (at least) three documentations to start contributing (esp with phabricator):
https://wiki.mozilla.org/Phabricator/FAQ
https://developer.mozilla.org/en-US/docs/Mozilla/Developer_guide/How_to_Submit_a_Patch
https://moz-conduit.readthedocs.io/en/latest/phabricator-user.html
(something that we should improve at some point)
Updated•6 years ago
|
Comment hidden (obsolete) |
Assignee | ||
Comment 3•6 years ago
|
||
This is a change suggested by static analysis: http://sylvestre.ledru.info/reports/fx-scan-build/report-TrackUnionStream.cpp-CopyTrackData-24-1.html#EndPath
The condition that triggers the line in question breaks out of the loop.
for (some range)
value = foo
if (condition) {
value = bar // the line in question
break;
}
/* use value */
end
So if the condition is triggered, we leave the loop before value
is used.
Assignee | ||
Comment 4•6 years ago
|
||
Local build and test confirmed. Requesting landing.
Reporter | ||
Comment 5•6 years ago
|
||
Should be marked as fixed only whem on mc
Reporter | ||
Updated•6 years ago
|
Reporter | ||
Comment 6•6 years ago
|
||
I used Lando
Assignee | ||
Updated•6 years ago
|
Reporter | ||
Comment 8•6 years ago
•
|
||
This is autoland, not mc
Comment 9•6 years ago
|
||
bugherder |
Updated•6 years ago
|
Description
•